Update support for custom granularity in other types #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
approved these changes
Nov 11, 2024
dbt_semantic_interfaces/transformations/remove_plural_from_window_granularity.py
Outdated
Show resolved
Hide resolved
WilliamDee
force-pushed
the
will/update-custom-grain-for-windows
branch
from
a88441c to
256eb9d
Compare
…string instead of TimeGranularity
WilliamDee
force-pushed
the
will/update-custom-grain-for-windows
branch
from
256eb9d to
3d873b0
Compare
WilliamDee
added a commit
to dbt-labs/metricflow
that referenced
this pull request
Dec 5, 2024
## Context We merged 2 breaking changes in DSI dbt-labs/dbt-semantic-interfaces#363 and dbt-labs/dbt-semantic-interfaces#365 which changed most spec typing that used time granularity to be a `str` instead of `TimeGranularity` to enable support for custom granularity. Similarly, there were additional breaking changes to the objects that requires passing in `custom_granularity_names`. This PR updates all those callsites to be compatible with the new version of DSI (to be released) Resolves SL-3097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support custom grain by switching the typing to be not on
TimeGranularityMetric.time_granularity-TimeGranularity -> strMetric.type_params.cumulative_type_params.grain_to_date-TimeGranularity -> strMetricInput.offset_to_grain-TimeGranularity -> strMetricTimeWindow.granularity-TimeGranularity -> straffects the followingMetric.type_params.conversion_type_params.windowMetric.type_params.cumulative_type_params.windowMetricInput.offset_windowChanges to
MetricTimeWindowBecause
MetricTimeWindow.granularityis now a string, we allow it to be not as strict when ensuring it's a valid granularity during initial yaml parsing (since we don't have access to the custom granularities). Then during validations, we will properly validate that it's a valid grain, and during the transformation step we will remove trailing 's'.Checklist
changie newto create a changelog entryResolves SL-2826