Default granularity bug fix: handle time dimensions with the same name #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
WilliamDee
approved these changes
Jul 3, 2024
| @@ -34,7 +38,7 @@ def transform_model(semantic_manifest: PydanticSemanticManifest) -> PydanticSema | |||
| continue | |||
|
|
|||
| default_granularity = TimeGranularity.DAY | |||
| seen_agg_time_dimensions: Set[TimeDimensionReference] = set() | |||
| seen_agg_time_dimensions: Set[Tuple[SemanticModel, TimeDimensionReference]] = set() | |||
There was a problem hiding this comment.
Im always wary of using larger objects in sets, so if we could change this to like a semanticmodelreference would be nice
plypaul
approved these changes
Jul 3, 2024
| @@ -49,11 +53,16 @@ def transform_model(semantic_manifest: PydanticSemanticManifest) -> PydanticSema | |||
| except AssertionError: | |||
| # This indicates the agg_time_dimension is misconfigured, which will fail elsewhere. | |||
| # Do nothing here to avoid disrupting the validation process. | |||
| logger.warning( | |||
| f"Agg time dimension '{agg_time_dimension_ref.element_name}' not found in model." | |||
| "This should raise a validation error elsewhere." | |||
There was a problem hiding this comment.
Where is it supposed to raise a validation error?
There was a problem hiding this comment.
| @@ -1,6 +1,6 @@ | |||
| [project] | |||
| name = "dbt-semantic-interfaces" | |||
| version = "0.6.3" | |||
| version = "0.6.4" | |||
There was a problem hiding this comment.
Can you move this to a separate PR?
There was a problem hiding this comment.
Shoot, sorry got Will's approval and merged before I got this 😅
There was a problem hiding this comment.
I have seen some people request separate PRs for these bumps, but I just find that it slows down development. What's your thought process on why we should separate them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found another bug in SetDefaultGranularityRule. If there are multiple
agg_time_dimensionswith the same name across semantic models, and they have different granularities, we'll only check one. Fixed here!Checklist
changie newto create a changelog entry