Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dev version #297

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Bump dev version #297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d33e441
Bump dev version
courtneyholcomb Jun 18, 2024
1168eaa
Add . for PEP
courtneyholcomb Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "dbt-semantic-interfaces"
version = "0.6.0"
version = "0.6.1dev0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.6.1.dev0

Copy link
Collaborator

@tlento tlento Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should this be 0.6.1.dev0 or should it be 0.7.0.dev0? We're on new feature kind of stuff, right? Whichever works, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the doc 😅 https://www.notion.so/dbtlabs/DSI-Build-Release-Process-48d94828e8b840abb8529f7501fb2c5b?pvs=4#21b373d41cf040f180648ba211ba374f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should bump to 0.7.0 unless it's a breaking change. If we do, it will require another round of bumping version requirements in core which should not be necessary for non-breaking changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the DSI and MF docs differ on the naming practices so that's why it feels like there's thrash here. https://www.notion.so/dbtlabs/Metricflow-Build-Release-Process-81023685d93a45da8211b05dc36b7bf8?pvs=4#9accf24d2929404ba7b9337ad21a33e3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to suit PEP!

description = 'The shared semantic layer definitions that dbt-core and MetricFlow use'
readme = "README.md"
requires-python = ">=3.8"
Expand Down
Loading