Update developer CI actions and package metadata to include Python 3.12 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supported Python version list published to PyPi did not include 3.12. Now it does.
We have a composite GitHub action for installing Python and Hatch, but it is pegged to Python 3.9 whereas we'd typically want to either test our minimum version (currently 3.8) or a matrix of supported versions. This parameterizes the action so we can pass in the version we would like to test, and updates existing callers accordingly.
The composite action for setting up a python env with an interpreter and hatch install now allows parameterized configuration, meaning we can use a python version matrix across all of our actions. This commit moves the pytest action to use the env setup helper, and updates the other actions to run a test matrix against our endpoint versions (currently 3.8 and 3.12) under the assumption that things working on the endpoints will also work in the middle. While we could test all versions, in practice the actions with this smaller test surface wouldn't really benefit from this, and any developer running into problems there should be able to fix and test version-specific problems independently.
|
The JSON schema action also passes on this PR. See https://github.com/dbt-labs/dbt-semantic-interfaces/actions/runs/7921098902 |
courtneyholcomb
approved these changes
Feb 15, 2024
tlento
changed the title
tlento
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR for updating to Python 3.12 was missing a metadata update
for publishing supported version ranges to package distributions.
While updating this I noticed that other actions were explicitly testing against
Python 3.9 due to a dependency on an old composite action hard-coded to
3.9 from way back when the Transform product only supported that Python version.
I've taken the liberty of updating all of these actions to use matrix strategies that
test either the complete set of supported Python versions (unit tests) or the min and
max supported Python versions (development-focused actions).