Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners #215

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add codeowners #215

merged 2 commits into from
Jan 9, 2024

Conversation

marcodamore
Copy link
Collaborator

As per our thread in #wg-dbt-core-semantic-layer, we've decided to require more code reviewers from Metricflow, core, and product owners to make sure the specs we merge to dsi are well reviewed

Resolves #

Description

Checklist

…quire more code reviewers from Metricflow, core, and product owners to make sure the specs we merge to dsi are well reviewed
Copy link

cla-bot bot commented Nov 21, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Marco d'Amore.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@cla-bot cla-bot bot added the cla:yes label Nov 21, 2023
@marcodamore marcodamore requested a review from Jstein77 November 21, 2023 20:03
@QMalcolm
Copy link
Collaborator

QMalcolm commented Jan 9, 2024

I added the Skip Changelog label to skip the changelog step.

@marcodamore marcodamore merged commit 20c06ce into main Jan 9, 2024
13 of 15 checks passed
@marcodamore marcodamore deleted the marco_add_codeowners branch January 9, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants