Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made DatePart an ExtendedEnum #207

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

DevonFulcher
Copy link
Contributor

@DevonFulcher DevonFulcher commented Nov 8, 2023

Description

Made DatePart an ExtendedEnum so that users don't have to worry about case when entering values into date_part(). Copy-pasted MF comment so that we can remove DatePart from MF.

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 8, 2023
@DevonFulcher DevonFulcher changed the title Make DatePart an ExtendedEnum Made DatePart an ExtendedEnum Nov 8, 2023
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We'll probably also want to get this backported

@DevonFulcher DevonFulcher merged commit b4c0a82 into main Nov 8, 2023
23 checks passed
@DevonFulcher DevonFulcher deleted the date_part_extended_enum branch November 8, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants