Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Update typing-extensions to require versions ~=4.4 (#194) #199

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

tlento
Copy link
Collaborator

@tlento tlento commented Oct 26, 2023

Support for the @override keyword was added with typing-extensions 4.4,
but the previous version spec made it possible for end users to encounter
errors when attempting to use dbt or MetricFlow.

Support for the `@override` keyword was added with typing-extensions 4.4,
but the previous version spec made it possible for end users to encounter
errors when attempting to use dbt or MetricFlow.
@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@tlento tlento requested a review from QMalcolm October 26, 2023 22:26
@tlento tlento changed the title Update typing-extensions to require versions >=4.4 (#194) [Backport] Update typing-extensions to require versions >=4.4 (#194) Oct 26, 2023
The typing-extensions project announced adherence to semver with
4.0.0, which means, at least in theory, 5.0 might include
breaking changes.

Rather than risk user packages auto-updating to backwards-incompatible
versions, we pin this back to ~=4.0, which is equivalent to >=4.0, <5.
@tlento tlento changed the title [Backport] Update typing-extensions to require versions >=4.4 (#194) [Backport] Update typing-extensions to require versions ~=4.4 (#194) Oct 26, 2023
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you 🙂

@tlento tlento merged commit 5ad7325 into 0.2.latest Oct 30, 2023
11 checks passed
@tlento tlento deleted the backport-typing-extensions-4.4 branch October 30, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants