Rename SavedQuery.group_bys to SavedQuery.group_by
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
plypaul--52--saved-queries-group-by
branch
from
9d011fe to
d2cb710
Compare
|
@QMalcolm - How do we go about handling this kind of rename on the |
We can't, at least not for dbt-core 1.7, and that is a for a few reasons
The only way to do this currently for dbt-core 1.7.0 and DSI 0.3.0 would be to support both, which also seems undesireable |
|
Also I have a few separate questions:
|
|
We'll put this into 0.4.0 and then jam that into the final cut of dbt-core 1.7.0 |
Closed
plypaul
changed the title
group_bys field in SavedQueries to group_bySavedQuery.group_bys to SavedQuery.group_by
plypaul
force-pushed
the
plypaul--52--saved-queries-group-by
branch
from
d2cb710 to
2678fea
Compare
|
@QMalcolm - Good point, created an issue in DSI and updated links. |
QMalcolm
added a commit
to dbt-labs/dbt-core
that referenced
this pull request
Oct 26, 2023
In dbt-labs/dbt-semantic-interfaces#186 we renamed `group_bys` to `group_by` in DSI (which went out in DSI 0.4.0). The original `group_bys` naming was a typo. This fixes that. This is a non-breaking change from the core perspective because saved queries are being introduced in 1.7.0, which has not been cut yet.
QMalcolm
added a commit
to dbt-labs/dbt-core
that referenced
this pull request
Nov 1, 2023
In dbt-labs/dbt-semantic-interfaces#186 we renamed `group_bys` to `group_by` in DSI (which went out in DSI 0.4.0). The original `group_bys` naming was a typo. This fixes that. This is a non-breaking change from the core perspective because saved queries are being introduced in 1.7.0, which has not been cut yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192
Description
Please see associated issue for more details.
Checklist
changie newto create a changelog entry