-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: Add support for Dimension(...).grain(...)
in where filter
#162
Conversation
SL-631 Where Clause & Group By Updates
At launch (tomorrow):
Post launch we update where clause to do this
We should discuss remove "Dimension" out of categorical (e..g, allow a user to do {{ 'customer__**country' }} rather than {{ Dimension('customer__**country') }} |
6867db7
to
8df2758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems fine to me, given my understanding of the changes and how the backport deployment works with core 1.6.x, but I'd like @QMalcolm to take a look to confirm this is backwards compatible with existing 1.6 installations. In particular, I think there are some changes to the where_filter_parser along with the file move here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unfortunately don't think we can back port this. Core imports the WhereFilterParser, and this changes that import path. Core's import of DSI is ~=0.2.0
in dbt-core 1.6.0
through 1.6.5
, if we backported and released this, all fresh installs of those versions would break.
Is that the only issue? If so, can we add an import alias to the backport then? We should be able to put in a module in the original location that imports this WhereFilterParser (or defines a WhereFilterParser class that wraps it, if there are API changes that need to be managed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevonFulcher brought up the idea of moving the where_filter_parser.py
file back out for the backport in slack, also @tlento brought it in an above comment. Combing through these changes, and imports of dbt-semantic-interfaces
in dbt-core
, I think we can get away with this by doing so.
8df2758
to
c72779f
Compare
c72779f
to
828752c
Compare
Yay! 🚢 |
Resolving: SL-631
Description
Due to MetricFlow's reliance on version 0.2.x of DSI, the updates to support
Dimension(...).grain(...)
need to be made to this branch as well. I just combined the work from these PRs into this one #156, #154, #152Checklist
changie new
to create a changelog entry