Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dimension.grain(...) in where/filter #152

Merged
merged 17 commits into from
Sep 20, 2023
Merged

Support for Dimension.grain(...) in where/filter #152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7faca70
added support for Dimension(...).grain
DevonFulcher Sep 15, 2023
1aff3c9
added test
DevonFulcher Sep 18, 2023
29eeceb
fixed formatting & linting
DevonFulcher Sep 18, 2023
23edab7
changie
DevonFulcher Sep 18, 2023
1c7b68a
moved query_interface to protocols directory
DevonFulcher Sep 19, 2023
584ef92
removed raise NotImplementedError in protocol. added abstractmethod d…
DevonFulcher Sep 19, 2023
3835584
removed alias
DevonFulcher Sep 19, 2023
5309a49
made error message more user friendly
DevonFulcher Sep 19, 2023
bcc6d8e
improved another error message
DevonFulcher Sep 19, 2023
e3ef46c
appending to time_dimension_call_parameter_sets
DevonFulcher Sep 20, 2023
3d7f5fe
added comments
DevonFulcher Sep 20, 2023
13ebd52
fixed error message
DevonFulcher Sep 20, 2023
804937a
slight language change
DevonFulcher Sep 20, 2023
a374894
fixed linter & formatter
DevonFulcher Sep 20, 2023
31a1bb0
Merge branch 'main' into dimension_dot_grain_support
DevonFulcher Sep 20, 2023
ef68e74
fixed import
DevonFulcher Sep 20, 2023
03dc547
fixed formatting
DevonFulcher Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbt_semantic_interfaces/parsing/where_filter/where_filter_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@


class EntityStub(ProtocolHint[QueryInterfaceEntity]):
"""An Entity implementation that does nothing to satisfy the protocol.
"""An Entity implementation that just satisfies the protocol.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 😁


QueryInterfaceEntity currently has no methods and the parameter set is created in the factory.
So, there is nothing to do here.
Expand Down
2 changes: 1 addition & 1 deletion dbt_semantic_interfaces/parsing/where_filter/where_filter_time_dimension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@


class TimeDimensionStub(ProtocolHint[QueryInterfaceTimeDimension]):
"""A TimeDimension implementation that does nothing to satisfy the protocol.
"""A TimeDimension implementation that just satisfies the protocol.

QueryInterfaceTimeDimension currently has no methods and the parameter set is created in the factory.
So, there is nothing to do here.
Expand Down
Loading