Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NodeRelation.schema_name -> NodeRelation.schema #107

Closed
wants to merge 1 commit into from

Conversation

peterallenwebb
Copy link

Resolves #106

Description

Rename NodeRelation.schema_name -> NodeRelation.schema

Checklist

@cla-bot cla-bot bot added the cla:yes label Jul 10, 2023
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb requested a review from QMalcolm July 10, 2023 22:58
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@QMalcolm
Copy link
Collaborator

Woof so I took a look at the CI errors, and it looks like the issue is that schema is a property that pydantics BaseModel adds to classes 🙃 That complicates things

@peterallenwebb
Copy link
Author

We probably just discovered why it was schema_name in the first place. I'll figure out what our options are.

@peterallenwebb
Copy link
Author

Abandoned for a different approach using an alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the 'schema_name' field on node_relation to simply 'schema'
2 participants