Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-1489] [Bug] The pydantic shim isn't being included in the wheel distributions of the package #241

Closed
1 task done
QMalcolm opened this issue Jan 4, 2024 · 0 comments · Fixed by #243
Closed
1 task done

[SL-1489] [Bug] The pydantic shim isn't being included in the wheel distributions of the package #241

QMalcolm opened this issue Jan 4, 2024 · 0 comments · Fixed by #243
Assignees
@Jstein77
Labels
Backport 0.4.latest Fix should be backported to 0.4.latest bug Something isn't working

Comments

@QMalcolm
Copy link
Collaborator

QMalcolm commented Jan 4, 2024 •
edited
Loading

Housekeeping

  • I am a maintainer of dbt-semantic-interfaces

Short description

When running hatch build two distributions of the package are created, a wheel and a tarball. The pydantic_shim.py is included in the tarball distribution, but not the wheel distribution.

Acceptance criteria

The pydantic shim is included in both the wheel distribution and tarball distribution

Impact to Other Teams

None

Will backports be required?

Yes. #238 was already backported to the branch 0.4.latest. Thus, this change will also need to be backported.

Context

No response

SL-1489
@QMalcolm QMalcolm added the Backport 0.4.latest Fix should be backported to 0.4.latest label Jan 4, 2024
@QMalcolm QMalcolm self-assigned this Jan 4, 2024
@QMalcolm QMalcolm changed the title [Bug] The pydantic shim isn't being included in the wheel distributions of the package [SL-1489] [Bug] The pydantic shim isn't being included in the wheel distributions of the package Jan 4, 2024
@QMalcolm QMalcolm added the bug Something isn't working label Jan 4, 2024
This was referenced Jan 4, 2024
Closed
Merged
@QMalcolm QMalcolm assigned Jstein77 and unassigned QMalcolm Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jstein77 Jstein77

Labels
Backport 0.4.latest Fix should be backported to 0.4.latest bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure wheel distribution includes pydantic shim dbt-labs/dbt-semantic-interfaces
2 participants
@QMalcolm @Jstein77