Remove name from time spine config

dbt-labs · Jul 25, 2024 · 79739d3 · 79739d3
1 parent d1bf57a
commit 79739d3
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 14 deletions.
diff --git a/dbt_semantic_interfaces/implementations/time_spine.py b/dbt_semantic_interfaces/implementations/time_spine.py
@@ -30,6 +30,5 @@ class PydanticTimeSpine(HashableBaseModel, ProtocolHint[TimeSpine]):
     def _implements_protocol(self) -> TimeSpine:
         return self
 
-    name: str
     node_relation: PydanticNodeRelation
     primary_column: PydanticTimeSpinePrimaryColumn
diff --git a/dbt_semantic_interfaces/parsing/schemas.py b/dbt_semantic_interfaces/parsing/schemas.py
@@ -362,12 +362,11 @@
     "$id": "time_spine_schema",
     "type": "object",
     "properties": {
-        "name": {"type": "string"},
         "node_relation": {"$ref": "node_relation_schema"},
         "primary_column": {"$ref": "time_spine_primary_column_schema"},
     },
     "additionalProperties": False,
-    "required": ["name", "node_relation", "primary_column"],
+    "required": ["node_relation", "primary_column"],
 }
 
 

diff --git a/dbt_semantic_interfaces/protocols/time_spine.py b/dbt_semantic_interfaces/protocols/time_spine.py
@@ -14,12 +14,6 @@ class TimeSpine(Protocol):
     custom granularity columns. Custom granularity columns are not yet implemented.
     """
 
-    @property
-    @abstractmethod
-    def name(self) -> str:
-        """A name the user assigns to this time spine."""
-        pass
-
     @property
     @abstractmethod
     def node_relation(self) -> NodeRelation:

diff --git a/tests/example_project_configuration.py b/tests/example_project_configuration.py
@@ -24,7 +24,6 @@
     ],
     time_spines=[
         PydanticTimeSpine(
-            name="day_time_spine",
             node_relation=PydanticNodeRelation(alias="day_time_spine", schema_name="stuff"),
             primary_column=PydanticTimeSpinePrimaryColumn(name="ds_day", time_granularity=TimeGranularity.DAY),
         )
@@ -41,8 +40,7 @@
               column_name: ds
               grain: day
           time_spines:
-            - name: day_time_spine
-              node_relation:
+            - node_relation:
                 schema_name: stuff
                 alias: day_time_spine
               primary_column:

diff --git a/tests/fixtures/semantic_manifest_yamls/simple_semantic_manifest/project_configuration.yaml b/tests/fixtures/semantic_manifest_yamls/simple_semantic_manifest/project_configuration.yaml
@@ -5,8 +5,7 @@ project_configuration:
       column_name: ds
       grain: day
   time_spines:
-    - name: day_time_spine
-      node_relation:
+    - node_relation:
         schema_name: stuff
         alias: day_time_spine
       primary_column: