Cl/support click round 2 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
force-pushed
the
cl/support-click-round-2
branch
from
8f6cbc2 to
4e9b489
Compare
|
After merging, we should:
@ChenyuLInx Does that sound right to you? |
jtcohen6
reviewed
Feb 17, 2023
dbt_rpc/__main__.py
Outdated
| @@ -596,6 +595,13 @@ def parse_args(args, cls=DBTArgumentParser): | |||
| expanded_user = os.path.expanduser(parsed.project_dir) | |||
| parsed.project_dir = os.path.abspath(expanded_user) | |||
|
|
|||
| # set_args construct a flags with command run | |||
| # which doesn't have defer_mode, but we need a default value | |||
| parsed.defer_mode = 'eager' | |||
There was a problem hiding this comment.
Isn't 'eager' for indirect_selection? Does this just need to be 'any_string'?
There was a problem hiding this comment.
Ha it is one of those places I didn't clean up properly. core moved this attribute to defer. Removing it completely in the most recent commit, and pointed things to defer
stu-k
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #122, #120