Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to 2.1.1 and below to fix the cursor error. #844

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Pin to 2.1.1 and below to fix the cursor error. #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e154d3e
Pin to 2.1.1 and below to fix the cursor error.
VersusFacit Jun 11, 2024
9fe7f0b
Update setup.py
colin-rogers-dbt Jun 12, 2024
f7be9c3
add changie
colin-rogers-dbt Jun 12, 2024
070021f
Merge branch 'main' into pin_for_redshift_connector_204_fix
colin-rogers-dbt Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240612-131752.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: update pin range for redshift-connector to allow 2.1.0
time: 2024-06-12T13:17:52.460407-07:00
custom:
Author: colin-rogers-dbt VersusFacit
Issue: "844"
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def _plugin_version_trim() -> str:
f"dbt-postgres~={_plugin_version_trim()}",
# dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases
# Pin to the patch or minor version, and bump in each new minor version of dbt-redshift.
"redshift-connector<2.0.918,>=2.0.913,!=2.0.914",
"redshift-connector<2.1.1,>=2.0.913,!=2.0.914",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to pin less than a specific patch? I know we've been broken in the past, but if this package is indicating that they're going to start using minors, then I would think we pin to 2.1, not 2.1.x.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should follow up with them and see if that's actually what's happening here or if they just decided to do a minor version bump

# add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency
"dbt-core>=1.8.0b3",
# installed via dbt-core but referenced directly; don't pin to avoid version conflicts with dbt-core
Expand Down
Loading