Hard pin to 2.1.0 #843
Closed
Hard pin to 2.1.0 #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
VersusFacit
force-pushed
the
adjust_redshift_connector_version
branch
from
c1ded87 to
a99d5cc
Compare
| @@ -64,7 +64,7 @@ def _plugin_version_trim() -> str: | |||
| f"dbt-postgres~={_plugin_version_trim()}", | |||
| # dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases | |||
| # Pin to the patch or minor version, and bump in each new minor version of dbt-redshift. | |||
| "redshift-connector<2.0.918,>=2.0.913,!=2.0.914", | |||
There was a problem hiding this comment.
Maybe we should just update the upper bound to <=2.1
There was a problem hiding this comment.
@colin-rogers-dbt I pinned it in alignment with our concern of unannounced breaking changes in the 2.1.0 family if that continues to be a real concern. This is also paired with the fact this branch is behind main. Going with a range does open us up to that.
Is that acceptable risk? Happy to make the adjustment if so
What about hard pinning this branch but using that range for main?
|
Closed as redundant with #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist