-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark flaky tests #813
Mark flaky tests #813
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
The integration tests workflow is updated as part of this PR. Here's a run against this branch: |
…ly testing on windows anyway
…in to the most recent version
Here's the latest integration tests run against this branch: |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-813-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b57890e3503928ced7dfd75de6985b348f0e7307
# Push it to GitHub
git push --set-upstream origin backport-813-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-813-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b57890e3503928ced7dfd75de6985b348f0e7307
# Push it to GitHub
git push --set-upstream origin backport-813-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-813-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b57890e3503928ced7dfd75de6985b348f0e7307
# Push it to GitHub
git push --set-upstream origin backport-813-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-813-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b57890e3503928ced7dfd75de6985b348f0e7307
# Push it to GitHub
git push --set-upstream origin backport-813-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-813-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b57890e3503928ced7dfd75de6985b348f0e7307
# Push it to GitHub
git push --set-upstream origin backport-813-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
* mark flaky tests using pytest.mark * split integration test runs by flaky and non-flaky * fix the posargs syntax for tox * force flaky tests to run in series, fix python version getting truncated * revert the integration test job name to match the existing names * separate flaky tests as a separate matrix of jobs * recombine the integration tests * allow integration tests to run fully in parallel for non-flaky tests * remove windows from integration test matrix since we weren't originally testing on windows anyway * add windows back in * register the custom marker with pytest * revert the combination of integration tests * configure a pytest return of 5 to be 0 * fix test order to avoid unnecessary change * mark more flaky tests * mark more flaky tests * pin windows images to 2019 to avoid datadog traceport failures * pinning windows images to 2019 didn't solve datadog issue, updating pin to the most recent version * turn off telemetry warnings (and telemetry) * mark more tests as flaky * mark more tests as flaky * incorporate feedback * incorporate feedback (cherry picked from commit b57890e)
* mark flaky tests using pytest.mark * split integration test runs by flaky and non-flaky * fix the posargs syntax for tox * force flaky tests to run in series, fix python version getting truncated * revert the integration test job name to match the existing names * separate flaky tests as a separate matrix of jobs * recombine the integration tests * allow integration tests to run fully in parallel for non-flaky tests * remove windows from integration test matrix since we weren't originally testing on windows anyway * add windows back in * register the custom marker with pytest * revert the combination of integration tests * configure a pytest return of 5 to be 0 * fix test order to avoid unnecessary change * mark more flaky tests * mark more flaky tests * pin windows images to 2019 to avoid datadog traceport failures * pinning windows images to 2019 didn't solve datadog issue, updating pin to the most recent version * turn off telemetry warnings (and telemetry) * mark more tests as flaky * mark more tests as flaky * incorporate feedback * incorporate feedback (cherry picked from commit b57890e)
resolves #770
Problem
We have a handful of flaky tests in
dbt-redshift
that routinely prevent CI from passing. It's not always the same test that fails. After a few runs, all tests have passed at least once, but it's rare that they all pass at the same time.Solution
pytest.mark
(e.g.@pytest.mark.flaky
)Checklist