Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin macos test runners to macos-12 #787

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Pin macos test runners to macos-12 #787

merged 1 commit into from
Apr 25, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

macos-latest now points to macos-14-arm64; it used to point to macos-12. There is no py39 nor py38 on macos-14-arm64.

Solution

Pin to macos-12 for now and discuss long term options to use macos-14-arm64, and CI pinning in general.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 25, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 25, 2024
@mikealfare mikealfare requested a review from a team April 25, 2024 13:28
@mikealfare mikealfare merged commit ddfc36c into main Apr 25, 2024
40 of 42 checks passed
@mikealfare mikealfare deleted the pin-macos-runners branch April 25, 2024 14:20
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
3ea5abb 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
65730b4 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
39bc838 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
eda60ef 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
1614b47 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
af05a7d 
(cherry picked from commit ddfc36c)
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
commit #787
683eb3f
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
backport #787
5b7a602
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
commit #787 (#794)
767610d
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#793)
04208fe 
(cherry picked from commit ddfc36c)
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#792)
cb56c16 
(cherry picked from commit ddfc36c)
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#789)
13435ab 
(cherry picked from commit ddfc36c)
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#788)
8395344 
(cherry picked from commit ddfc36c)
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#791)
7bdabae 
(cherry picked from commit ddfc36c)
colin-rogers-dbt pushed a commit that referenced this pull request Apr 25, 2024
@mikealfare
backport #787 (#795)
26935e7
mikealfare added a commit that referenced this pull request Apr 25, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#790)
c3b4d77 
(cherry picked from commit ddfc36c)
mikealfare added a commit that referenced this pull request Apr 26, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
f6e9c57 
(cherry picked from commit ddfc36c)
mikealfare added a commit that referenced this pull request Apr 26, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
163895b 
(cherry picked from commit ddfc36c)
mikealfare added a commit that referenced this pull request Apr 26, 2024
@mikealfare
pin macos-runners to macos-12 (#787)
eb88300 
(cherry picked from commit ddfc36c)
mikealfare added a commit that referenced this pull request May 8, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#797)
4b72580 
(cherry picked from commit ddfc36c)
mikealfare added a commit that referenced this pull request May 8, 2024
@mikealfare
pin macos-runners to macos-12 (#787) (#798)
a0bed16 
(cherry picked from commit ddfc36c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @emmyoop