Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker release to the full release process for final releases #758

Merged
merged 24 commits into from
May 21, 2024
Merged

Add docker release to the full release process for final releases #758

merged 24 commits into from
May 21, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 5, 2024 •
edited
Loading

Problem

Publishing a Docker release is currently a manual process which can be forgotten.

Solution

Add the Docker release to the release pipeline.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 5, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 5, 2024
@mikealfare mikealfare marked this pull request as draft April 5, 2024 22:05
@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Apr 5, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 2H 1M 0L 1I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 2H 1M 0L 1I
Secrets 0🔑

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare mentioned this pull request Apr 5, 2024
Closed
3 tasks
@mikealfare mikealfare linked an issue Apr 10, 2024 that may be closed by this pull request
[Feature] Automate Docker Release dbt-labs/dbt-release#109
Closed
3 tasks
@mikealfare mikealfare marked this pull request as ready for review April 13, 2024 02:32
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 15, 2024
VersusFacit
VersusFacit previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One call for some refactoring but otherwise looking good.

docker/test.sh Outdated Show resolved Hide resolved
@VersusFacit VersusFacit dismissed their stale review April 16, 2024 20:56

Apparently tests are failing? :(

emmyoop
emmyoop reviewed Apr 24, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@mikealfare
Copy link
Contributor Author

mikealfare commented May 2, 2024 •
edited
Loading

Test release using this branch:
https://github.com/dbt-labs/dbt-redshift/actions/runs/9082734687

@mikealfare mikealfare requested a review from a team as a code owner May 13, 2024 20:44
VersusFacit
VersusFacit reviewed May 20, 2024
View reviewed changes
docker/test.sh Outdated Show resolved Hide resolved
VersusFacit
VersusFacit approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise matches the PG PR

@mikealfare mikealfare merged commit 3b6de5b into main May 21, 2024
27 checks passed
@mikealfare mikealfare deleted the config/docker-release branch May 21, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop left review comments

@VersusFacit VersusFacit VersusFacit approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Automate Docker Release
3 participants
@mikealfare @emmyoop @VersusFacit