Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableLastModifiedMetadataBatch capability #744

Merged
merged 12 commits into from
Apr 18, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Mar 28, 2024

resolves #755
docs dbt-labs/docs.getdbt.com/#

Problem

  • dbt-redshift adapter metadata-based freshness can be computed in batch by using the base adapter implementation of calculate_source_freshness_from_metadata_batch, but the capability has not yet been enabled

Solution

  • enable capability + add tests (continued with pattern of individual test (not inherited) in this file)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Mar 28, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@MichelleArk
Copy link
Contributor Author

The verify packages CI check is failing on Check wheel distrubutions with:

AttributeError: TableLastModifiedMetadataBatch. Did you mean: 'TableLastModifiedMetadata'?

It seems like the branch setting of batch-metadata-freshness on dbt-adapters does not propagate to that step. It should be resolved once dbt-labs/dbt-adapters#127 is merged.

@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) April 18, 2024 19:56
@colin-rogers-dbt colin-rogers-dbt merged commit b8d330b into main Apr 18, 2024
30 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the batch-metadata-freshness branch April 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Batch Metadata Freshness
2 participants