Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Python driver 2.0.918 causes SSL error. Need to revert back to 2.0.917 #731

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Mar 17, 2024

resolves #730

Problem

A bug causing an SSL error was introduced to redshift-connector in 2.0.918.

Solution

We need to pin redshift-connector to <2.0.917 to resolve the issue for now. We will need to determine a long term solution, which may be as simple as skipping 2.0.918, as we did with 2.0.914, after redshift-connector resolves the underlying issue.

This will need to be backported to 1.7.latest, where it was introduced.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge till you get it green 😎

@mikealfare mikealfare merged commit f92ec48 into main Mar 20, 2024
26 checks passed
@mikealfare mikealfare deleted the bug/redshift-connector/2-0-918 branch March 20, 2024 17:38
@amychen1776
Copy link

@mikealfare was this released?I don't see it in the changelog.

@mikealfare
Copy link
Contributor Author

@mikealfare was this released?I don't see it in the changelog.

Nope, nope it wasn't. Not sure how we missed that.

github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
…2.0.917 (#731)

* cap redshift-connector at 2.0.917 to avoid ssl issue in 2.0.918

* changie

(cherry picked from commit f92ec48)
mikealfare added a commit that referenced this pull request Apr 2, 2024
…2.0.917 (#731) (#753)

* cap redshift-connector at 2.0.917 to avoid ssl issue in 2.0.918

* changie

(cherry picked from commit f92ec48)

Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Python driver 2.0.918 causes SSL error. Need to revert back to 2.0.917
3 participants