Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on sqlparse that used to inherit from core #728

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Add explicit dependency on sqlparse that used to inherit from core #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3503281
add explicit dependency on sqlparse that used to inherit from core
mikealfare Mar 2, 2024
a2127f6
update build verification command
mikealfare Mar 2, 2024
2ab27c6
remove core installation check since it is no longer installed
mikealfare Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
python -m pip --version
pre-commit --version
mypy --version
dbt --version
mikealfare marked this conversation as resolved.
Show resolved Hide resolved

- name: pre-commit hooks
run: pre-commit run --all-files --show-diff-on-failure
Expand Down Expand Up @@ -204,12 +203,12 @@ jobs:

- name: Check wheel distributions
run: |
dbt --version
python -c "import dbt.adapters.redshift"

- name: Install source distributions
run: |
find ./dist/*.gz -maxdepth 1 -type f | xargs python -m pip install --force-reinstall --find-links=dist/

- name: Check source distributions
run: |
dbt --version
python -c "import dbt.adapters.redshift"
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ on:
package_test_command:
description: "Package test command"
type: string
default: "dbt --version"
default: "python -c \"import dbt.adapters.redshift\""
required: true
test_run:
description: "Test run (Publish release as draft)"
Expand Down Expand Up @@ -92,7 +92,7 @@ on:
package_test_command:
description: "Package test command"
type: string
default: "dbt --version"
default: "python -c \"import dbt.adapters.redshift\""
required: true
test_run:
description: "Test run (Publish release as draft)"
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def _plugin_version() -> str:
# Pin to the patch or minor version, and bump in each new minor version of dbt-redshift.
"redshift-connector<=2.0.918, >=2.0.913, !=2.0.914",
# installed via dbt-core but referenced directly; don't pin to avoid version conflicts with dbt-core
"sqlparse>=0.2.3,<0.5",
"agate",
],
zip_safe=False,
Expand Down
Loading