Fix the renamed relations code #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
force-pushed
the
ADAP-722/add_test_for_PR_9682_in_core
branch
from
3da474c to
91ec795
Compare
mikealfare
reviewed
Feb 27, 2024
VersusFacit
force-pushed
the
ADAP-722/add_test_for_PR_9682_in_core
branch
from
1fee3c2 to
9b0f759
Compare
mikealfare
requested changes
Mar 20, 2024
dev-requirements.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| # install latest changes in dbt-core + dbt-postgres | |||
| git+https://github.com/dbt-labs/dbt-adapters.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@ADAP-108/fix_renamed_relations_for_1.8 | |||
There was a problem hiding this comment.
Adding a blocking review to make sure we don't accidentally merge this.
mikealfare
approved these changes
Mar 21, 2024
mikealfare
approved these changes
Mar 21, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-723-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c99c73bd0386e2641c825b8e36c5bc0229cd3258
# Push it to GitHub
git push --set-upstream origin backport-723-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latestThen, create a pull request where the |
mikealfare
pushed a commit
that referenced
this pull request
Mar 21, 2024
* Add test * Add FrozenSet to imports * removed extraneous semicolons * update alter table to alter view for rename --------- Co-authored-by: Mila Page <[email protected]> Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit c99c73b)
mikealfare
added a commit
that referenced
this pull request
Mar 21, 2024
* Fix the renamed relations code (#723) * Add test * Add FrozenSet to imports * removed extraneous semicolons * update alter table to alter view for rename --------- Co-authored-by: Mila Page <[email protected]> Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit c99c73b) * fix import for de-coupling work --------- Co-authored-by: Mila Page <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #722
Add a test after changing frozenset instantiation in Relation.
Checklist