Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of metadata-based freshness #694

Merged
merged 13 commits into from
Feb 26, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 19, 2023

resolves #615

Problem

The current implementation of source freshness requires querying the data and requires the user provide a datetime field. This is slower and more expensive than it should be. It doesn't scale across multiple models. And some models do not have an appropriate datetime field.

Solution

Use source metadata where available.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 19, 2023
@cla-bot cla-bot bot added the cla:yes label Dec 19, 2023
@mikealfare mikealfare marked this pull request as ready for review February 21, 2024 04:14
@mikealfare mikealfare requested a review from a team as a code owner February 21, 2024 04:14
@mikealfare mikealfare marked this pull request as draft February 26, 2024 16:41
@mikealfare mikealfare marked this pull request as ready for review February 26, 2024 18:15
@mikealfare mikealfare merged commit d77f5ee into main Feb 26, 2024
15 checks passed
@mikealfare mikealfare deleted the source-freshness/metadata-based branch February 26, 2024 21:26
Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-694-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d77f5ee9561bf11eae56b2832340e3c11005b6f9
# Push it to GitHub
git push --set-upstream origin backport-694-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-694-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-911] Support Metadata Freshness
2 participants