Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #674 to 1.7.latest #678

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Backport #674 to 1.7.latest #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Dependencies-20231130-044332.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Dependencies
body: Remove direct boto3 dependency
time: 2023-11-30T04:43:32.872452+11:00
custom:
Author: hexDoor
PR: "674"
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ def _core_version(plugin_version: str = _plugin_version()) -> str:
install_requires=[
f"dbt-core~={_core_version()}",
f"dbt-postgres~={_core_version()}",
"boto3~=1.26.157",
# dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases
# Pin to the patch or minor version, and bump in each new minor version of dbt-redshift.
"redshift-connector==2.0.915",
Expand Down
1 change: 1 addition & 0 deletions tests/functional/adapter/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class TestBaseAdapterMethod(BaseAdapterMethod):
pass


@pytest.mark.skip(reason="Known flakey test to be reviewed")
class TestDocsGenerateRedshift(BaseDocsGenerate):
@pytest.fixture(scope="class")
def expected_catalog(self, project, profile_user):
Expand Down
6 changes: 0 additions & 6 deletions tests/unit/test_redshift_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ def test_conn_timeout_30(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_explicit_iam_conn_with_profile(self):
self.config.credentials = self.config.credentials.replace(
method="iam",
Expand Down Expand Up @@ -173,7 +172,6 @@ def test_explicit_iam_conn_with_profile(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_explicit_iam_serverless_with_profile(self):
self.config.credentials = self.config.credentials.replace(
method="iam",
Expand All @@ -200,7 +198,6 @@ def test_explicit_iam_serverless_with_profile(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_explicit_region(self):
# Successful test
self.config.credentials = self.config.credentials.replace(
Expand Down Expand Up @@ -229,7 +226,6 @@ def test_explicit_region(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_explicit_region_failure(self):
# Failure test with no region
self.config.credentials = self.config.credentials.replace(
Expand Down Expand Up @@ -259,7 +255,6 @@ def test_explicit_region_failure(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_explicit_invalid_region(self):
# Invalid region test
self.config.credentials = self.config.credentials.replace(
Expand Down Expand Up @@ -384,7 +379,6 @@ def test_sslmode_prefer(self):
)

@mock.patch("redshift_connector.connect", Mock())
@mock.patch("boto3.Session", Mock())
def test_serverless_iam_failure(self):
self.config.credentials = self.config.credentials.replace(
method="iam",
Expand Down