Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-891: Support test results as views #614

Merged
merged 9 commits into from
Oct 10, 2023
Merged

ADAP-891: Support test results as views #614

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5711601
implement tests for persist test results
mikealfare Sep 21, 2023
979aa76
implement tests for persist test results
mikealfare Sep 21, 2023
6b9b883
update changelog and test names to reflect renamed parameter
mikealfare Sep 29, 2023
fb9a86e
Merge branch 'main' into feature/materialized-tests/adap-891
mikealfare Sep 29, 2023
b71ab34
implement store-failures-as tests
mikealfare Oct 3, 2023
0cb4d52
Merge branch 'main' into feature/materialized-tests/adap-891
mikealfare Oct 3, 2023
0d1672d
revert dev requirements to point back to main on dbt-core
mikealfare Oct 10, 2023
f3a250b
update tests to include recent tests from dbt-core
mikealfare Oct 10, 2023
974bb54
Merge remote-tracking branch 'origin/feature/materialized-tests/adap-…
mikealfare Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20230921-153707.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Support storing test failures as views
time: 2023-09-21T15:37:07.970722-04:00
custom:
Author: mikealfare
Issue: "6914"
6 changes: 3 additions & 3 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# install latest changes in dbt-core + dbt-postgres
# TODO: how to switch from HEAD to x.y.latest branches after minor releases?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-postgres&subdirectory=plugins/postgres
git+https://github.com/dbt-labs/dbt-core.git@feature/materialized-tests/adap-850#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@feature/materialized-tests/adap-850#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@feature/materialized-tests/adap-850#egg=dbt-postgres&subdirectory=plugins/postgres

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
24 changes: 23 additions & 1 deletion tests/functional/adapter/test_store_test_failures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,29 @@
from dbt.tests.adapter.store_test_failures_tests.basic import (
StoreTestFailuresAsGeneric,
StoreTestFailuresAsInteractions,
StoreTestFailuresAsProjectLevelOff,
StoreTestFailuresAsProjectLevelView,
)
from dbt.tests.adapter.store_test_failures_tests.test_store_test_failures import (
TestStoreTestFailures,
)


class RedshiftTestStoreTestFailures(TestStoreTestFailures):
class TestRedshiftTestStoreTestFailures(TestStoreTestFailures):
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
pass


class TestRedshiftStoreTestFailuresAsInteractions(StoreTestFailuresAsInteractions):
pass


class TestRedshiftStoreTestFailuresAsProjectLevelOff(StoreTestFailuresAsProjectLevelOff):
pass


class TestRedshiftStoreTestFailuresAsProjectLevelView(StoreTestFailuresAsProjectLevelView):
pass


class TestRedshiftStoreTestFailuresAsGeneric(StoreTestFailuresAsGeneric):
pass