Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grant and revoke for Redshift grantees with special characters #282

Closed
wants to merge 2 commits into from
Closed

Fix grant and revoke for Redshift grantees with special characters #282

wants to merge 2 commits into from

Conversation

mp24-git
Copy link

@mp24-git mp24-git commented Jan 26, 2023

resolves dbt-labs/dbt-core#277 and addresses dbt-labs/dbt-adapters#156 for Redshift

Description

Grantees in the grant and revoke SQL commands in Redshift can be quoted using double quotes. This avoids issues with user names that contain special characters such as . or : (in case of IAM role grants).

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 26, 2023
@mp24-git
Copy link
Author

I have tested it with "normal" users for the grant and revoke workflows. I have also tested this for IAMR: based users based on the issue dbt-labs/dbt-core#277

@github-actions
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better support for cloning large dbt packages
1 participant