-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAP-474] [Feature] Accept users, groups, or roles in grants config on resource #415
Comments
Thanks for following up @stevenayers-tvx ! Only granting to (and revoking from) Redshift users was explicitly covered in the original implementation of grants in #131 -- granting/revoking for Redshift groups and roles was not. This deserves clarification in the docs, and I've opened dbt-labs/docs.getdbt.com#3245 accordingly. I'm going to convert this into a feature request to add support for grants for Redshift groups and roles. |
[Preview](https://deploy-preview-3245--docs-getdbt-com.netlify.app/reference/resource-configs/grants#database-specific-requirements-and-notes) > click "Redshift" tab ## What are you changing in this pull request and why? Redshift has users, groups, and roles. But the grants functionality only fully supports users (and not groups or roles). See dbt-labs/dbt-redshift#415 for more context. ## Checklist - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) and [About versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) so my content adheres to these guidelines. - [x] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch." --------- Co-authored-by: mirnawong1 <[email protected]>
We use this extensively, and intentional or not it seems that just using
|
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers. |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers. |
Reopening as the PR that relates to it is still open |
Is this a new bug in dbt-redshift?
Current Behavior
After specifically creating the group
finance_department
in Redshift, I cannot use it as a grantee in the grant config.I can see the group when I run
SELECT * FROM pg_group
Error:
user "finance_department" does not exist
Expected Behavior
Grantee syntax says groups, not just users, should be accepted: https://docs.getdbt.com/reference/resource-configs/grants#common-syntax
Steps To Reproduce
Relevant log output
No response
Environment
Additional Context
No response
The text was updated successfully, but these errors were encountered: