Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests: to data_tests: #471

Closed
wants to merge 1 commit into from

Conversation

tuebolo
Copy link

@tuebolo tuebolo commented Jul 2, 2024

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Description & motivation

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@b-per
Copy link
Collaborator

b-per commented Jul 2, 2024

Thanks for this.

We should definitely update the convention when we make the package valid for 1.8+ only (and do a new release with this restriction).

But I think that there was a recent issue fixed in dbt-core to stop warnings for tests => data_tests for packages. So, those warnings should soon disappear even without this PR.

@tuebolo tuebolo closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants