Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Use a list instead of a set for index changes to perserve order #73

Merged
merged 5 commits into from
Apr 25, 2024
Merged

[Bug] Use a list instead of a set for index changes to perserve order #73

merged 5 commits into from
Apr 25, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 25, 2024 •
edited
Loading

resolves #72

Problem

We are using a set for the index changes on materialized views. A set is not ordered, which leads to the changes occasionally happening out of order. This is a problem when an index with the same name is being replaced as that has to happen in a particular order (drop first).

Solution

Use a list instead of a set.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 25, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
@mikealfare mikealfare marked this pull request as ready for review April 25, 2024 18:39
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
McKnight-42
McKnight-42 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@mikealfare mikealfare requested a review from a team April 25, 2024 19:01
@mikealfare mikealfare merged commit cf10056 into main Apr 25, 2024
18 checks passed
@mikealfare mikealfare deleted the bug/72 branch April 25, 2024 22:26
@mikealfare mikealfare mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 left review comments

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] unordered set causing statements to be executed in incorrect order
3 participants
@mikealfare @McKnight-42 @colin-rogers-dbt