Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip inapplicable test that compares dbt-core's version to that of dbt-postgres #45

Closed
wants to merge 1 commit into from

Conversation

mikealfare
Copy link
Contributor

Problem

The test compares dbt-core's version to that of dbt-postgres. This is not always true though, as different versions could be published to PyPI at the same time.

Solution

  • Manually inspect the test to ensure the actual expected version is there
  • Skip the test
  • Release
  • Resolve the test in the future, or elect to remove it as these two packages are now decoupled

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 3, 2024
@mikealfare mikealfare closed this Apr 3, 2024
@mikealfare mikealfare deleted the skip-version-check-test branch April 3, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant