Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1123: Create the package subdirectory #176

Merged
merged 22 commits into from
Dec 11, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 1, 2024

Problem

We need to move files into a package sub-directory to prepare for merging into the monorepo. This needs to be done in such a way that existing pull requests can be rebased against monorepo/stage to pick up those file migrations.

Solution

  • use git mv when moving files or directories to pick up those file migrations in git history
  • update workflows to reference the new sub-directory where applicable
  • verify a branch created off of main can be rebased on monorepo/stage

I tested this by:

  • create a branch off of main (called test for reference here)
  • make updates to a method in PostgresAdapter
  • make updates to a macro
  • commit these changes in test
  • rebase test onto monorepo/subpackage-namespace (this branch)
  • observe that the changes occurred as expected, in the moved files, leaving no orphan files behind
  • ensuring the CI still passes given the new workflows

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 1, 2024
@mikealfare mikealfare requested a review from a team as a code owner December 1, 2024 16:43
@cla-bot cla-bot bot added the cla:yes label Dec 1, 2024
@mikealfare mikealfare changed the title Create the package subdirectory ADAP-1123: Create the package subdirectory Dec 4, 2024
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tallyho

@mikealfare mikealfare merged commit 3798eb1 into monorepo/stage Dec 11, 2024
25 checks passed
@mikealfare mikealfare deleted the monorepo/subpackage-namespace branch December 11, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants