Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snapshot tests #127

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Remove snapshot tests #127

merged 3 commits into from
Jul 16, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jul 15, 2024

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Duplication of tests in core and dbt-postgres.

Solution

I'm working on a lot of snapshot tickets, and we don't want test duplication. Most of these tests look like config type tests, which logically could belong to core. If there are some that should be re-implemented in dbt-adapters, let me know and I can open a follow-up ticket.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner July 15, 2024 14:53
@cla-bot cla-bot bot added the cla:yes label Jul 15, 2024
@gshank gshank assigned mikealfare and unassigned mikealfare Jul 15, 2024
@gshank gshank requested a review from mikealfare July 15, 2024 14:54
@colin-rogers-dbt
Copy link
Contributor

I think we can just update the base snapshot tests in place to reference what we already have dbt-adapters: https://github.com/dbt-labs/dbt-adapters/tree/main/dbt-tests-adapter/dbt/tests/adapter/simple_snapshot

@gshank
Copy link
Contributor Author

gshank commented Jul 15, 2024

I can update it to pull in the dbt-adapters snapshot test.

@gshank
Copy link
Contributor Author

gshank commented Jul 15, 2024

Actually the dbt-tests-adapter test is already pulled in: tests/functional/shared_tests/test_simple_snapshot.py

Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clearing this up!

@colin-rogers-dbt colin-rogers-dbt merged commit 7a4c021 into main Jul 16, 2024
21 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the remove_snapshot_tests branch July 16, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants