Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #106

Merged
merged 7 commits into from
May 23, 2024
Merged

Fix release workflow #106

merged 7 commits into from
May 23, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

  • audit core team did not specify a job dependency
  • audit core team was not passing secrets to the action
  • audit version had a typo
  • release branch resolution had a syntax error

Solution

  • fix all of the above
  • run a test release to demonstrate that it's working

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 23, 2024
@mikealfare mikealfare requested a review from a team as a code owner May 23, 2024 15:43
@cla-bot cla-bot bot added the cla:yes label May 23, 2024
@mikealfare
Copy link
Contributor Author

This created a draft release:

The GitHub draft release will be removed to make room for the real release once this is merged.

@mikealfare mikealfare merged commit 0717373 into main May 23, 2024
18 checks passed
@mikealfare mikealfare deleted the fix-release-workflow branch May 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants