-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for spaces and quotes in jinja block matching #208
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,12 +20,146 @@ | |
{% enddocs %} | ||
""" | ||
|
||
no_leading_space = """\ | ||
|
||
|
||
{%docs customer_id %} | ||
The unique key for each customer. | ||
{% enddocs %} | ||
""" | ||
|
||
no_trailing_space = """\ | ||
|
||
|
||
{% docs customer_id%} | ||
The unique key for each customer. | ||
{% enddocs %} | ||
""" | ||
|
||
no_spaces = """\ | ||
|
||
|
||
{%docs customer_id%} | ||
The unique key for each customer. | ||
{% enddocs %} | ||
""" | ||
|
||
no_spaces_end_docs = """\ | ||
|
||
|
||
{%docs customer_id%} | ||
The unique key for each customer. | ||
{%enddocs%} | ||
""" | ||
|
||
special_character = """\ | ||
|
||
|
||
{% docs cust-omer_id %} | ||
The unique key for each customer. | ||
{% enddocs %} | ||
""" | ||
|
||
simple_macro = """\ | ||
|
||
|
||
{% macro test_macro(name) %} | ||
{{ name }} | ||
{% endmacro %} | ||
""" | ||
|
||
simple_macro_no_spaces = """\ | ||
|
||
|
||
{%macro test_macro(name)%} | ||
{{ name }} | ||
{%endmacro%} | ||
""" | ||
|
||
simple_macro_space_to_args = """\ | ||
|
||
|
||
{% macro test_macro (name) %} | ||
{{ name }} | ||
{% endmacro %} | ||
""" | ||
|
||
simple_macro_string_defaults = """\ | ||
|
||
|
||
{% macro test_macro(name='dave') %} | ||
{{ name }} | ||
{% endmacro %} | ||
""" | ||
|
||
simple_macro_string_defaults_double_quotes = """\ | ||
|
||
|
||
{% macro test_macro(name="dave") %} | ||
{{ name }} | ||
{% endmacro %} | ||
""" | ||
|
||
simple_macro_int_defaults = """\ | ||
|
||
|
||
{% macro test_macro(num=8) %} | ||
{{ num }} | ||
{% endmacro %} | ||
""" | ||
|
||
|
||
class TestJinjaBlock: | ||
def test_from_file_detects_block_range(self): | ||
range = JinjaBlock.find_block_range(string, "docs", "customer_id") | ||
assert range == (2, 72) | ||
|
||
def test_from_file_detects_block_range_no_leading_space(self): | ||
range = JinjaBlock.find_block_range(no_leading_space, "docs", "customer_id") | ||
assert range == (2, 71) | ||
|
||
def test_from_file_detects_block_range_no_trailing_space(self): | ||
range = JinjaBlock.find_block_range(no_trailing_space, "docs", "customer_id") | ||
assert range == (2, 71) | ||
|
||
def test_from_file_detects_block_range_no_spaces(self): | ||
range = JinjaBlock.find_block_range(no_spaces, "docs", "customer_id") | ||
assert range == (2, 70) | ||
|
||
def test_from_file_detects_block_range_no_spaces_end_docs(self): | ||
range = JinjaBlock.find_block_range(no_spaces_end_docs, "docs", "customer_id") | ||
assert range == (2, 68) | ||
|
||
def test_from_file_detects_block_range_special_character(self): | ||
range = JinjaBlock.find_block_range(special_character, "docs", "cust-omer_id") | ||
assert range == (2, 73) | ||
Comment on lines
+133
to
+135
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm happy to see that the inner dash is still identified correctly! |
||
|
||
def test_from_file_detects_block_range_simple_macro(self): | ||
range = JinjaBlock.find_block_range(simple_macro, "macro", "test_macro") | ||
assert range == (2, 58) | ||
|
||
def test_from_file_detects_block_range_simple_macro_no_spaces(self): | ||
range = JinjaBlock.find_block_range(simple_macro_no_spaces, "macro", "test_macro") | ||
assert range == (2, 54) | ||
|
||
def test_from_file_detects_block_range_simple_macro_space_to_args(self): | ||
range = JinjaBlock.find_block_range(simple_macro_space_to_args, "macro", "test_macro") | ||
assert range == (2, 59) | ||
|
||
def test_from_file_detects_block_range_simple_macro_string_defaults(self): | ||
range = JinjaBlock.find_block_range(simple_macro_string_defaults, "macro", "test_macro") | ||
assert range == (2, 65) | ||
|
||
def test_from_file_detects_block_range_simple_macro_string_defaults_double_quotes(self): | ||
range = JinjaBlock.find_block_range( | ||
simple_macro_string_defaults_double_quotes, "macro", "test_macro" | ||
) | ||
assert range == (2, 65) | ||
|
||
def test_from_file_detects_block_range_simple_macro_int_defaults(self): | ||
range = JinjaBlock.find_block_range(simple_macro_int_defaults, "macro", "test_macro") | ||
assert range == (2, 58) | ||
|
||
def test_from_file_extracts_content(self): | ||
content = JinjaBlock.isolate_content(string, 2, 72) | ||
assert ( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call swapping the
+
for*
!