Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update refs in exposure and semantic model definitions when downstream of a split resource #194

Merged
merged 14 commits into from
Mar 13, 2024
Merged

update refs in exposure and semantic model definitions when downstream of a split resource #194

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c187597
add an exposure to the project
dave-connors-3 Jan 15, 2024
59f89ed
add basic function to update exposure depends on field
dave-connors-3 Jan 15, 2024
b26c8c4
add test for updating exposure depends on
dave-connors-3 Jan 15, 2024
3b95b34
add semantic model and time spine, use dbt 1.7
dave-connors-3 Jan 15, 2024
f283e6c
update dbt
dave-connors-3 Jan 15, 2024
aa004af
update references to include semantic models
dave-connors-3 Jan 15, 2024
2472420
dummy test
dave-connors-3 Jan 15, 2024
283f291
exclude semantic models from grouper
dave-connors-3 Jan 15, 2024
785b35d
typo
dave-connors-3 Jan 16, 2024
e61faaa
change name of semantic model
dave-connors-3 Jan 16, 2024
934eabc
reinstate test to show semantic models are updated
dave-connors-3 Jan 16, 2024
70a2e1a
Merge branch 'main' into exposures
dave-connors-3 Jan 31, 2024
8fb895f
remove clunky else if
dave-connors-3 Feb 29, 2024
ec95adf
early returns
dave-connors-3 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions dbt_meshify/utilities/references.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,31 +182,29 @@ def generate_reference_update(
model_code=code,
)

change = FileChange(
return FileChange(
operation=Operation.Update,
entity_type=EntityType.Code,
identifier=downstream_node.name,
path=downstream_project.resolve_file_path(downstream_node),
data=updated_code,
)

else:
if isinstance(downstream_node, Exposure) or isinstance(downstream_node, SemanticModel):
is_exposure = isinstance(downstream_node, Exposure)
data = self.update_yml_resource_references(
project_name=project_name,
upstream_resource_name=upstream_node.name,
resource=downstream_node,
)
change = ResourceChange(
operation=Operation.Update,
entity_type=EntityType.Exposure if is_exposure else EntityType.SemanticModel,
identifier=downstream_node.name,
path=downstream_project.resolve_file_path(downstream_node),
data=data,
)

return change
elif isinstance(downstream_node, Exposure) or isinstance(downstream_node, SemanticModel):
is_exposure = isinstance(downstream_node, Exposure)
data = self.update_yml_resource_references(
project_name=project_name,
upstream_resource_name=upstream_node.name,
resource=downstream_node,
)
return ResourceChange(
operation=Operation.Update,
entity_type=EntityType.Exposure if is_exposure else EntityType.SemanticModel,
identifier=downstream_node.name,
path=downstream_project.resolve_file_path(downstream_node),
data=data,
)
raise Exception("Invalid node type provided to generate_reference_update.")
Comment on lines +193 to +207
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic Doctor Who GIF


def update_child_refs(
self,
Expand Down
Loading