Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass --read-catalog to both group subcommands #182

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dave-connors-3
Copy link
Collaborator

closes #181

Makes sure we properly pass the read catalog flag to the second invocation nested in dbt-meshify group !

@dave-connors-3 dave-connors-3 changed the title pass param to second command, add test pass --read-catalog to both group subcommands Sep 28, 2023
@nicholasyager nicholasyager added the bug Something isn't working label Sep 30, 2023
Copy link
Collaborator

@nicholasyager nicholasyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dave-connors-3 I appreciate how straightforward the fix here is. Kudos for adding the test. ✅ 🚀

@dave-connors-3 dave-connors-3 merged commit e1c65b9 into main Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when using group --read-catalog only applied to first of 2 sub commands
2 participants