Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows snapshots to have a list of unique keys #9993

Closed
wants to merge 3 commits into from
+9 −3
Closed

Allows snapshots to have a list of unique keys #9993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a88879
Allows a snapshot to have a list as a unique_key
AGPapa Apr 22, 2024
b25f28f
Adds changie
AGPapa Apr 22, 2024
cffc43d
Merge branch 'main' into snapshot-unique-keys
AGPapa May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20240422-082925.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Allows snapshots to take a list as a unique_key
time: 2024-04-22T08:29:25.458309-04:00
custom:
Author: agpapa
Issue: "9992"
2 changes: 1 addition & 1 deletion core/dbt/artifacts/resources/v1/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
class SnapshotConfig(NodeConfig):
materialized: str = "snapshot"
strategy: Optional[str] = None
unique_key: Optional[str] = None
target_schema: Optional[str] = None
target_database: Optional[str] = None
updated_at: Optional[str] = None
# Not using Optional because of serialization issues with a Union of str and List[str]
unique_key: Union[str, List[str], None] = None
check_cols: Union[str, List[str], None] = None

@classmethod
Expand Down
4 changes: 2 additions & 2 deletions core/dbt/contracts/graph/model_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dataclasses import dataclass, field
from typing import Any, Dict, List, Optional, Type
from typing import Any, Dict, List, Optional, Type, Union

from dbt.artifacts.resources import (
ExposureConfig,
Expand Down Expand Up @@ -42,7 +42,7 @@ class UnitTestNodeConfig(NodeConfig):
@dataclass
class EmptySnapshotConfig(NodeConfig):
materialized: str = "snapshot"
unique_key: Optional[str] = None # override NodeConfig unique_key definition
unique_key: Union[str, List[str], None] = None # override NodeConfig unique_key definition


RESOURCE_TYPES: Dict[NodeType, Type[BaseConfig]] = {
Expand Down
Loading