-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from unittest to pytest for manifestLoader #9960
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9960 +/- ##
==========================================
- Coverage 88.18% 88.11% -0.07%
==========================================
Files 181 181
Lines 22593 22593
==========================================
- Hits 19923 19908 -15
- Misses 2670 2685 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Here is the one big issue: #9961 |
Additionally I think we can skip the changelog for these changes as long as all the changes are contained to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we should drop the changelog though and fix the merge conflicts
#9961
converted
test_parse_manfiest.py
from unit test to pytest and moved it around.Problem
Solution
Checklist