Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from unittest to pytest for manifestLoader #9960

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Apr 16, 2024

#9961
converted test_parse_manfiest.py from unit test to pytest and moved it around.

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner April 16, 2024 22:41
@cla-bot cla-bot bot added the cla:yes label Apr 16, 2024
@ChenyuLInx ChenyuLInx requested a review from QMalcolm April 16, 2024 22:44
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (4811ada) to head (bceae81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9960      +/-   ##
==========================================
- Coverage   88.18%   88.11%   -0.07%     
==========================================
  Files         181      181              
  Lines       22593    22593              
==========================================
- Hits        19923    19908      -15     
- Misses       2670     2685      +15     
Flag Coverage Δ
integration 85.42% <ø> (-0.15%) ⬇️
unit 62.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx
Copy link
Contributor Author

@QMalcolm @emmyoop any suggestions on creating issues for these changes/not? I guess we can maybe have one issue for reorganize and all link to it?

@QMalcolm
Copy link
Contributor

Here is the one big issue: #9961

@QMalcolm
Copy link
Contributor

Additionally I think we can skip the changelog for these changes as long as all the changes are contained to /tests. Changelog is really for the distributed source code I believe, and thus don't make much sense for this kind of work.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should drop the changelog though and fix the merge conflicts

@ChenyuLInx ChenyuLInx requested a review from QMalcolm April 19, 2024 17:46
@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Apr 19, 2024
@ChenyuLInx ChenyuLInx requested a review from gshank April 19, 2024 17:51
@ChenyuLInx ChenyuLInx merged commit 5c8a4ab into main Apr 19, 2024
62 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/update_to_pytest branch April 19, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants