-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly release & Docker drafts #9954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9954 +/- ##
==========================================
+ Coverage 88.08% 88.11% +0.03%
==========================================
Files 180 180
Lines 22546 22546
==========================================
+ Hits 19859 19867 +8
+ Misses 2687 2679 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit (x4)
resolves #
Problem
Nightly releases failed for having the wrong permissions.
Additionally, Docker released fail on a draft release since the tag does not exist.
Solution
Add the
package: write
permission to the nightly releaseDo not release to Docker when we are running the release as a test
Allow the release to only release to Docker when a flag is flipped. This will allow us to release to Docker as needed if the final release already exists.
Checklist