Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly release & Docker drafts #9954

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Fix nightly release & Docker drafts #9954

merged 6 commits into from
Apr 16, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 16, 2024

resolves #

Problem

Nightly releases failed for having the wrong permissions.

Additionally, Docker released fail on a draft release since the tag does not exist.

Solution

Add the package: write permission to the nightly release
Do not release to Docker when we are running the release as a test
Allow the release to only release to Docker when a flag is flipped. This will allow us to release to Docker as needed if the final release already exists.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 16, 2024
@emmyoop emmyoop marked this pull request as ready for review April 16, 2024 14:46
@emmyoop emmyoop requested a review from a team as a code owner April 16, 2024 14:46
@emmyoop emmyoop requested a review from mikealfare April 16, 2024 14:46
@emmyoop emmyoop changed the title Er/fix nightly release Fix nightly release & Docker drafts Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (11dbe67) to head (3ffc7bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9954      +/-   ##
==========================================
+ Coverage   88.08%   88.11%   +0.03%     
==========================================
  Files         180      180              
  Lines       22546    22546              
==========================================
+ Hits        19859    19867       +8     
+ Misses       2687     2679       -8     
Flag Coverage Δ
integration 85.50% <ø> (+0.11%) ⬆️
unit 62.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Apr 16, 2024
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit (x4)

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@emmyoop emmyoop merged commit 4c1d0e9 into main Apr 16, 2024
60 checks passed
@emmyoop emmyoop deleted the er/fix-nightly-release branch April 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants