Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop bumping version in DockerFile #9950

Merged
merged 1 commit into from
Apr 16, 2024
Merged

stop bumping version in DockerFile #9950

merged 1 commit into from
Apr 16, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 16, 2024

resolves #

Problem

We no longer define the version in the Dockerfile and it's causing an error during version bump

Solution

Exclude it from the files to version bump. This does not need to be backported.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Apr 16, 2024
@emmyoop emmyoop requested a review from a team as a code owner April 16, 2024 01:04
@cla-bot cla-bot bot added the cla:yes label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (ee74a60) to head (07ed687).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9950      +/-   ##
==========================================
- Coverage   88.09%   88.06%   -0.04%     
==========================================
  Files         180      180              
  Lines       22546    22546              
==========================================
- Hits        19863    19856       -7     
- Misses       2683     2690       +7     
Flag Coverage Δ
integration 85.37% <ø> (-0.04%) ⬇️
unit 62.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop merged commit 11dbe67 into main Apr 16, 2024
72 checks passed
@emmyoop emmyoop deleted the er/docker-versions-bump branch April 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants