Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify docker release process in the release pipeline #9928

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We simplified the docker release process and delegated the adapter-specific releases to the adapter repos. We need to reflect that in dbt-core

Solution

  • remove references to first party adapters
  • remove dbt-core from the build arg, we only need the version

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@mikealfare mikealfare self-assigned this Apr 12, 2024
@mikealfare mikealfare requested a review from a team as a code owner April 12, 2024 21:47
@cla-bot cla-bot bot added the cla:yes label Apr 12, 2024
@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Apr 12, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 1H 1M 1L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 1M 1L 0I
Secrets 0🔑

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare linked an issue Apr 12, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (a1f0057) to head (5d4ed80).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9928      +/-   ##
==========================================
- Coverage   88.15%   88.05%   -0.11%     
==========================================
  Files         178      180       +2     
  Lines       22455    22546      +91     
==========================================
+ Hits        19796    19852      +56     
- Misses       2659     2694      +35     
Flag Coverage Δ
integration 85.35% <ø> (-0.25%) ⬇️
unit 62.04% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 15, 2024
@mikealfare mikealfare merged commit ee74a60 into main Apr 15, 2024
64 of 66 checks passed
@mikealfare mikealfare deleted the config/docker-release branch April 15, 2024 21:26
@dbeatty10 dbeatty10 mentioned this pull request Sep 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Automate Docker Release
2 participants