Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from custom _error_tag to dbt-common defined error_tag #9927

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

QMalcolm
Copy link
Contributor

resolves #9914

Problem

In #9886 we added a stop gap _error_tag which really should have been in dbt-common. We have since added it to dbt-common as error_tag and the release of dbt-common 1.0.1 made it publicly available. Thus we needed to clean things up by migrating to that newly dbt-common provided function

Solution

  • Upgrade to dbt-common 1.0.1
  • drop custom _error_tag
  • use dbt-common provided error_tag

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

In the next commit we're going to begin importing `error_tag` from `dbt-common`.
Howver, `error_tag` doesn't exist in dbt-common `1.0.0`, but only in versions
`1.0.1` or later. Thus are minimum spec for `dbt-common` must move up to
`1.0.1`.
@QMalcolm QMalcolm requested a review from a team as a code owner April 12, 2024 20:49
@cla-bot cla-bot bot added the cla:yes label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (cb56f4f) to head (449e048).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9927      +/-   ##
==========================================
- Coverage   88.13%   88.12%   -0.01%     
==========================================
  Files         178      178              
  Lines       22546    22544       -2     
==========================================
- Hits        19871    19867       -4     
- Misses       2675     2677       +2     
Flag Coverage Δ
integration 85.51% <100.00%> (-0.02%) ⬇️
unit 62.02% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm merged commit c53d67d into main Apr 12, 2024
68 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--9914-move-to-dbt-common-error-tag branch April 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop custom _error_tag and use error_tag provided by dbt-common
2 participants