Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search for dbt_core source distribution #9915

Merged
merged 1 commit into from
Apr 12, 2024
Merged

search for dbt_core source distribution #9915

merged 1 commit into from
Apr 12, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Apr 12, 2024

resolves #N/A

Problem

setuptools released a patch that enforcing a naming standard on source distributions to use '_' instead of '-'. this breaks our regex-based search in CI: https://github.com/dbt-labs/dbt-core/actions/runs/8665429967/job/23764102566?pr=9891

https://setuptools.pypa.io/en/stable/history.html

pypa/setuptools#4300

Solution

update regex to search using _ also updating to only search for dbt_core explicitly since we no longer build other distributions in this step.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (3c4456d) to head (ef512ae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9915      +/-   ##
==========================================
- Coverage   88.09%   88.08%   -0.02%     
==========================================
  Files         178      178              
  Lines       22459    22459              
==========================================
- Hits        19786    19782       -4     
- Misses       2673     2677       +4     
Flag Coverage Δ
integration 85.44% <ø> (-0.02%) ⬇️
unit 61.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review April 12, 2024 17:56
@MichelleArk MichelleArk requested a review from a team as a code owner April 12, 2024 17:56
@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Apr 12, 2024
@MichelleArk MichelleArk requested a review from mikealfare April 12, 2024 17:59
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is only run on main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants