Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for customization of the environment in which test fixtures are… #9894

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

peterallenwebb
Copy link
Contributor

Problem

Tests are failing due to changes in the way environment is managed by dbt.

Solution

Allow the environment to be modified by tests so that they can affect the way fixtures are processed.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@peterallenwebb peterallenwebb added the Skip Changelog Skips GHA to check for changelog file label Apr 11, 2024
@peterallenwebb peterallenwebb requested a review from a team as a code owner April 11, 2024 17:25
@cla-bot cla-bot bot added the cla:yes label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (a1f0057) to head (b1262c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9894      +/-   ##
==========================================
- Coverage   88.15%   88.08%   -0.08%     
==========================================
  Files         178      178              
  Lines       22455    22459       +4     
==========================================
- Hits        19796    19782      -14     
- Misses       2659     2677      +18     
Flag Coverage Δ
integration 85.44% <100.00%> (-0.16%) ⬇️
unit 61.87% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Let's get it merged

@peterallenwebb peterallenwebb merged commit c86cec3 into main Apr 11, 2024
62 checks passed
@peterallenwebb peterallenwebb deleted the paw/test-fixture-env branch April 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants