-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changlogs, remove PR reference #9887
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9887 +/- ##
==========================================
- Coverage 88.14% 88.09% -0.05%
==========================================
Files 178 178
Lines 22455 22455
==========================================
- Hits 19793 19782 -11
- Misses 2662 2673 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-9887-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b44c2e498dfd634a3b4a51f4441afce5a3c7e8c7
# Push it to GitHub
git push --set-upstream origin backport-9887-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
* stop referencing PRs * convert PR to Issue in older yaml # Conflicts: # .changes/1.8.0/Dependencies-20231005-151848.yaml # .changes/1.8.0/Dependencies-20231031-131954.yaml # .changes/1.8.0/Dependencies-20231106-130051.yaml # .changes/1.8.0/Dependencies-20231122-001840.yaml # .changes/1.8.0/Dependencies-20231204-000945.yaml # .changes/1.8.0/Dependencies-20231211-005651.yaml # .changes/1.8.0/Dependencies-20240115-012030.yaml # .changes/1.8.0/Dependencies-20240123-105843.yaml # .changes/1.8.0/Dependencies-20240129-005734.yaml # .changes/1.8.0/Dependencies-20240129-005743.yaml # .changes/1.8.0/Dependencies-20240212-011324.yaml # .changes/1.8.0/Dependencies-20240222-102947.yaml # .changes/1.8.0/Dependencies-20240226-004412.yaml # .changes/1.8.0/Dependencies-20240226-123502.yaml # .changes/1.8.0/Dependencies-20240227-151115.yaml # .changes/1.8.0/Security-20240222-152445.yaml # .changes/unreleased/Dependencies-20240117-100818.yaml
resolves #
Problem
A
Dependency
changelog referenced an Issue instead of a PR. This caused changelog generation to fail because the PR tag was missing but required.Solution
Since GitHub treats PRs and Issue as the same thing, I removed all references to PR and only use Issue in the yaml files. The links will still build correctly because issues and prs are the same thing under the hood for GitHub.
I also updated the bot changelog to use Issue instead of PR in the yaml it auto generates.
This was tested by locally running the changie batch commands to ensure changelogs can be generated.
Checklist