[#9791] Fix datetime.datetime.utcnow() is deprecated as of Python 3.12

.changes/unreleased/Fixes-20240329-223653.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: datetime.datetime.utcnow() is deprecated as of Python 3.12
+time: 2024-03-29T22:36:53.504295426+01:00
+custom:
+  Author: slothkong
+  Issue: "9791"

core/dbt/artifacts/schemas/base.py

@@ -60,7 +60,7 @@ def read(cls, path: str):
 class BaseArtifactMetadata(dbtClassMixin):
     dbt_schema_version: str
     dbt_version: str = __version__
-    generated_at: datetime = dataclasses.field(default_factory=datetime.utcnow)
+    generated_at: datetime = dataclasses.field(default_factory=datetime.now)
     invocation_id: Optional[str] = dataclasses.field(default_factory=get_invocation_id)
     env: Dict[str, str] = dataclasses.field(default_factory=get_metadata_vars)
 

core/dbt/artifacts/schemas/results.py

@@ -8,7 +8,7 @@
 from dbt_common.dataclass_schema import dbtClassMixin, StrEnum
 
 from dataclasses import dataclass
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import Any, Callable, Dict, List, Optional, Sequence, Union
 
 
@@ -19,10 +19,10 @@ class TimingInfo(dbtClassMixin):
     completed_at: Optional[datetime] = None
 
     def begin(self):
-        self.started_at = datetime.utcnow()
+        self.started_at = datetime.now(timezone.utc).replace(tzinfo=None)
 
     def end(self):
-        self.completed_at = datetime.utcnow()
+        self.completed_at = datetime.now(timezone.utc).replace(tzinfo=None)
 
     def to_msg_dict(self):
         msg_dict = {"name": self.name}

core/dbt/artifacts/schemas/run/v5/run.py

@@ -90,7 +90,7 @@ class RunExecutionResult(
 ):
     results: Sequence[RunResult]
     args: Dict[str, Any] = field(default_factory=dict)
-    generated_at: datetime = field(default_factory=datetime.utcnow)
+    generated_at: datetime = field(default_factory=datetime.now)
 
     def write(self, path: str):
         writable = RunResultsArtifact.from_execution_results(

core/dbt/contracts/graph/node_args.py

@@ -18,7 +18,7 @@ class ModelNodeArgs:
     latest_version: Optional[NodeVersion] = None
     deprecation_date: Optional[datetime] = None
     access: Optional[str] = AccessType.Protected.value
-    generated_at: datetime = field(default_factory=datetime.utcnow)
+    generated_at: datetime = field(default_factory=datetime.now)
     depends_on_nodes: List[str] = field(default_factory=list)
     enabled: bool = True
 

core/dbt/contracts/sql.py

@@ -34,7 +34,7 @@
 @dataclass
 @schema_version("remote-compile-result", 1)
 class RemoteCompileResult(RemoteCompileResultMixin):
-    generated_at: datetime = field(default_factory=datetime.utcnow)
+    generated_at: datetime = field(default_factory=datetime.now)
 
     @property
     def error(self):
@@ -46,7 +46,7 @@
 class RemoteExecutionResult(ExecutionResult, RemoteResult):
     results: Sequence[RunResult]
     args: Dict[str, Any] = field(default_factory=dict)
-    generated_at: datetime = field(default_factory=datetime.utcnow)
+    generated_at: datetime = field(default_factory=datetime.now)
 
     def write(self, path: str):
         writable = RunResultsArtifact.from_execution_results(
@@ -82,4 +82,4 @@
 @schema_version("remote-run-result", 1)
 class RemoteRunResult(RemoteCompileResultMixin):
     table: ResultTable
-    generated_at: datetime = field(default_factory=datetime.utcnow)
+    generated_at: datetime = field(default_factory=datetime.now)

core/dbt/logger.py

@@ -7,7 +7,7 @@
 import time
 import warnings
 from dataclasses import dataclass
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import Optional, List, ContextManager, Callable, Dict, Any, Set
 
 import logbook
@@ -295,7 +295,7 @@
 
     def process(self, record):
         super().process(record)
-        record.extra[self.name] = datetime.utcnow().isoformat()
+        record.extra[self.name] = datetime.now(timezone.utc).replace(tzinfo=None).isoformat()
 
 
 class ScrubSecrets(logbook.Processor):

core/dbt/parser/manifest.py

@@ -1,7 +1,7 @@
 from copy import deepcopy
 from dataclasses import dataclass
 from dataclasses import field
-import datetime
+from datetime import timezone, datetime, date
 import os
 import traceback
 from typing import (
@@ -146,10 +146,10 @@
 
 
 def extended_msgpack_encoder(obj):
-    if type(obj) is datetime.date:
+    if type(obj) is date:
         date_bytes = msgpack.ExtType(1, obj.isoformat().encode())
         return date_bytes
-    elif type(obj) is datetime.datetime:
+    elif type(obj) is datetime:
         datetime_bytes = msgpack.ExtType(2, obj.isoformat().encode())
         return datetime_bytes
 
@@ -162,10 +162,10 @@
 
 def extended_msgpack_decoder(code, data):
     if code == 1:
-        d = datetime.date.fromisoformat(data.decode())
+        d = date.fromisoformat(data.decode())
         return d
     elif code == 2:
-        dt = datetime.datetime.fromisoformat(data.decode())
+        dt = datetime.fromisoformat(data.decode())
         return dt
     else:
         return msgpack.ExtType(code, data)
@@ -590,7 +590,7 @@
             if isinstance(node, ModelNode):
                 if (
                     node.deprecation_date
-                    and node.deprecation_date < datetime.datetime.now().astimezone()
+                    and node.deprecation_date < datetime.now(timezone.utc).astimezone()
                 ):
                     warn_or_error(
                         DeprecatedModel(
@@ -605,7 +605,7 @@
                 node.depends_on
                 for resolved_ref in resolved_model_refs:
                     if resolved_ref.deprecation_date:
-                        if resolved_ref.deprecation_date < datetime.datetime.now().astimezone():
+                        if resolved_ref.deprecation_date < datetime.now(timezone.utc).astimezone():
                             event_cls = DeprecatedReference
                         else:
                             event_cls = UpcomingReferenceDeprecation
@@ -901,7 +901,9 @@
                 is_partial_parsable, reparse_reason = self.is_partial_parsable(manifest)
                 if is_partial_parsable:
                     # We don't want to have stale generated_at dates
-                    manifest.metadata.generated_at = datetime.datetime.utcnow()
+                    manifest.metadata.generated_at = datetime.now(timezone.utc).replace(
+                        tzinfo=None
+                    )
                     # or invocation_ids
                     manifest.metadata.invocation_id = get_invocation_id()
                     return manifest

core/dbt/task/base.py

@@ -4,7 +4,7 @@
 import traceback
 from abc import ABCMeta, abstractmethod
 from contextlib import nullcontext
-from datetime import datetime
+from datetime import timezone, datetime
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Type, Union, Set
 
@@ -232,7 +232,8 @@ def run_with_hooks(self, manifest):
 
         result = self.safe_run(manifest)
         self.node.update_event_status(
-            node_status=result.status, finished_at=datetime.utcnow().isoformat()
+            node_status=result.status,
+            finished_at=datetime.now(timezone.utc).replace(tzinfo=None).isoformat(),
         )
 
         if not self.node.is_ephemeral_model:

core/dbt/task/docs/generate.py

@@ -1,7 +1,7 @@
 import os
 import shutil
 from dataclasses import replace
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import Dict, List, Any, Optional, Tuple, Set, Iterable
 import agate
 from itertools import chain
@@ -226,7 +226,7 @@ def run(self) -> CatalogArtifact:
                 return CatalogArtifact.from_results(
                     nodes={},
                     sources={},
-                    generated_at=datetime.utcnow(),
+                    generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
                     errors=None,
                     compile_results=compile_results,
                 )
@@ -306,7 +306,7 @@ def run(self) -> CatalogArtifact:
         results = self.get_catalog_results(
             nodes=nodes,
             sources=sources,
-            generated_at=datetime.utcnow(),
+            generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
             compile_results=compile_results,
             errors=errors,
         )

core/dbt/task/run.py

@@ -11,7 +11,7 @@
     print_run_end_messages,
     get_counts,
 )
-from datetime import datetime
+from datetime import timezone, datetime
 from dbt import tracking
 from dbt import utils
 from dbt.adapters.base import BaseRelation
@@ -366,7 +366,8 @@ def run_hooks(self, adapter, hook_type: RunHookType, extra_context) -> None:
             # log_contextvars
             with log_contextvars(node_info=hook.node_info):
                 hook.update_event_status(
-                    started_at=datetime.utcnow().isoformat(), node_status=RunningStatus.Started
+                    started_at=datetime.now(timezone.utc).replace(tzinfo=None).isoformat(),
+                    node_status=RunningStatus.Started,
                 )
                 sql = self.get_hook_sql(adapter, hook, idx, num_hooks, extra_context)
 
@@ -391,7 +392,9 @@ def run_hooks(self, adapter, hook_type: RunHookType, extra_context) -> None:
                             status = "OK"
 
                     self.ran_hooks.append(hook)
-                    hook.update_event_status(finished_at=datetime.utcnow().isoformat())
+                    hook.update_event_status(
+                        finished_at=datetime.now(timezone.utc).replace(tzinfo=None).isoformat()
+                    )
                     with finishctx, DbtModelState({"node_status": "passed"}):
                         hook.update_event_status(node_status=RunStatus.Success)
                         fire_event(

core/dbt/task/run_operation.py

@@ -1,7 +1,7 @@
 import os
 import threading
 import traceback
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import TYPE_CHECKING
 
 import dbt_common.exceptions
@@ -51,7 +51,7 @@ def _run_unsafe(self, package_name, macro_name) -> "agate.Table":
         return res
 
     def run(self) -> RunResultsArtifact:
-        start = datetime.utcnow()
+        start = datetime.now(timezone.utc).replace(tzinfo=None)
         self.compile_manifest()
 
         success = True
@@ -69,7 +69,7 @@ def run(self) -> RunResultsArtifact:
             fire_event(LogDebugStackTrace(exc_info=traceback.format_exc()))
             success = False
 
-        end = datetime.utcnow()
+        end = datetime.now(timezone.utc).replace(tzinfo=None)
 
         macro = (
             self.manifest.find_macro_by_name(macro_name, self.config.project_name, package_name)

core/dbt/task/runnable.py

@@ -2,7 +2,7 @@
 import time
 from abc import abstractmethod
 from concurrent.futures import as_completed
-from datetime import datetime
+from datetime import timezone, datetime
 from multiprocessing.dummy import Pool as ThreadPool
 from pathlib import Path
 from typing import AbstractSet, Optional, Dict, List, Set, Tuple, Iterable
@@ -210,7 +210,8 @@ def call_runner(self, runner: BaseRunner) -> RunResult:
             startctx = TimestampNamed("node_started_at")
             index = self.index_offset(runner.node_index)
             runner.node.update_event_status(
-                started_at=datetime.utcnow().isoformat(), node_status=RunningStatus.Started
+                started_at=datetime.now(timezone.utc).replace(tzinfo=None).isoformat(),
+                node_status=RunningStatus.Started,
             )
             extended_metadata = ModelMetadata(runner.node, index)
 
@@ -424,7 +425,7 @@ def execute_nodes(self):
             run_result = self.get_result(
                 results=self.node_results,
                 elapsed_time=time.time() - self.started_at,
-                generated_at=datetime.utcnow(),
+                generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
             )
 
             if self.args.write_json and hasattr(run_result, "write"):
@@ -502,7 +503,9 @@ def execute_with_hooks(self, selected_uids: AbstractSet[str]):
             elapsed = time.time() - self.started_at
             self.print_results_line(self.node_results, elapsed)
             result = self.get_result(
-                results=self.node_results, elapsed_time=elapsed, generated_at=datetime.utcnow()
+                results=self.node_results,
+                elapsed_time=elapsed,
+                generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
             )
 
         return result
@@ -527,7 +530,7 @@ def run(self):
                 warn_or_error(NothingToDo())
                 result = self.get_result(
                     results=[],
-                    generated_at=datetime.utcnow(),
+                    generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
                     elapsed_time=0.0,
                 )
             else:

core/dbt/task/sql.py

@@ -1,5 +1,5 @@
 from abc import abstractmethod
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import Generic, TypeVar
 import traceback
 
@@ -68,7 +68,7 @@
             node=compiled_node,
             timing=[],  # this will get added later
             logs=[],
-            generated_at=datetime.utcnow(),
+            generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
         )
 
     def from_run_result(self, result, start_time, timing_info) -> RemoteCompileResult:
@@ -78,7 +78,7 @@
             node=result.node,
             timing=timing_info,
             logs=[],
-            generated_at=datetime.utcnow(),
+            generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
         )
 
 
@@ -98,7 +98,7 @@
             table=table,
             timing=[],
             logs=[],
-            generated_at=datetime.utcnow(),
+            generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
         )
 
     def from_run_result(self, result, start_time, timing_info) -> RemoteRunResult:
@@ -109,5 +109,5 @@
             table=result.table,
             timing=timing_info,
             logs=[],
-            generated_at=datetime.utcnow(),
+            generated_at=datetime.now(timezone.utc).replace(tzinfo=None),
         )

core/dbt/tests/fixtures/project.py

@@ -3,7 +3,7 @@
 import pytest  # type: ignore
 import random
 from argparse import Namespace
-from datetime import datetime
+from datetime import timezone, datetime
 import warnings
 import yaml
 
@@ -70,7 +70,9 @@
 def prefix():
     # create a directory name that will be unique per test session
     _randint = random.randint(0, 9999)
-    _runtime_timedelta = datetime.utcnow() - datetime(1970, 1, 1, 0, 0, 0)
+    _runtime_timedelta = datetime.now(timezone.utc).replace(tzinfo=None) - datetime(
+        1970, 1, 1, 0, 0, 0
+    )
     _runtime = (int(_runtime_timedelta.total_seconds() * 1e6)) + _runtime_timedelta.microseconds
     prefix = f"test{_runtime}{_randint:04}"
     return prefix

core/dbt/tests/util.py

@@ -5,7 +5,7 @@
 import yaml
 import json
 import warnings
-from datetime import datetime
+from datetime import timezone, datetime
 from typing import Any, Dict, List, Optional
 from contextlib import contextmanager
 from dbt.adapters.factory import Adapter
@@ -287,7 +287,7 @@ def check_result_nodes_by_unique_id(results, unique_ids):
 def check_datetime_between(timestr, start, end=None):
     datefmt = "%Y-%m-%dT%H:%M:%S.%fZ"
     if end is None:
-        end = datetime.utcnow()
+        end = datetime.now(timezone.utc).replace(tzinfo=None)
     parsed = datetime.strptime(timestr, datefmt)
     assert start <= parsed
     assert end >= parsed