Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] rename node, realnode to unique_id, node in selector_methods.py #9837

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 29, 2024

Tidy first change: rename node, realnode to unique_id, node in selector_methods.py

@gshank gshank added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Mar 29, 2024
@gshank gshank requested a review from a team as a code owner March 29, 2024 17:56
@cla-bot cla-bot bot added the cla:yes label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.05%. Comparing base (02d7727) to head (c006f73).

Files Patch % Lines
core/dbt/graph/selector_methods.py 95.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9837      +/-   ##
==========================================
- Coverage   88.12%   88.05%   -0.07%     
==========================================
  Files         178      178              
  Lines       22458    22458              
==========================================
- Hits        19790    19775      -15     
- Misses       2668     2683      +15     
Flag Coverage Δ
integration 85.41% <71.42%> (-0.17%) ⬇️
unit 61.78% <77.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a satisfying cleanup.

@gshank gshank merged commit 71f3519 into main Mar 29, 2024
76 checks passed
@gshank gshank deleted the tidy_first_selector_methods branch March 29, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants