Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate docker release #9833

Merged
merged 8 commits into from
Apr 2, 2024
Merged

automate docker release #9833

merged 8 commits into from
Apr 2, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 28, 2024

resolves dbt-labs/dbt-release#109

Problem

We miss releasing docker images often

Solution

Delete Docker release workflow and move it to dbt-release since it's not just used by the core team dbt-labs/dbt-release#108

Add docker generation to end of release

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (02d7727) to head (619414c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9833      +/-   ##
==========================================
- Coverage   88.12%   88.07%   -0.05%     
==========================================
  Files         178      178              
  Lines       22458    22458              
==========================================
- Hits        19790    19779      -11     
- Misses       2668     2679      +11     
Flag Coverage Δ
integration 85.43% <ø> (-0.15%) ⬇️
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop requested a review from mikealfare March 29, 2024 02:15
@emmyoop emmyoop force-pushed the er/automate-docker-in-release branch 3 times, most recently from c96ba5d to 38e0eb1 Compare March 29, 2024 16:20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to dbt-release in dbt-labs/dbt-release#108 since it's shared by all adapters + core

@emmyoop emmyoop marked this pull request as ready for review April 2, 2024 17:51
@emmyoop emmyoop requested a review from a team as a code owner April 2, 2024 17:51
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval, assuming the defaults that looks like testing parameters are removed prior to merging.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@emmyoop emmyoop merged commit 0d87d31 into main Apr 2, 2024
60 checks passed
@emmyoop emmyoop deleted the er/automate-docker-in-release branch April 2, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Automate Docker Release
2 participants