Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker release process for dbt-postgres #9828

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Mar 27, 2024

resolves #9827

Problem

We updated the Docker release process for the new location of dbt-postgres. This broke the process for previous versions of dbt-postgres, which still live in dbt-core's repo.

Solution

  • add the subdirectory back to the repo reference, which only works for dbt-postgres<1.8
  • handle the docker releases for dbt-postgres>=1.8 in the new dbt-postgres repo

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@mikealfare mikealfare self-assigned this Mar 27, 2024
@mikealfare mikealfare requested a review from a team as a code owner March 27, 2024 19:04
@cla-bot cla-bot bot added the cla:yes label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (f683e36) to head (d3c886e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9828      +/-   ##
==========================================
- Coverage   88.10%   88.07%   -0.04%     
==========================================
  Files         178      178              
  Lines       22458    22458              
==========================================
- Hits        19786    19779       -7     
- Misses       2672     2679       +7     
Flag Coverage Δ
integration 85.43% <ø> (-0.04%) ⬇️
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare mikealfare marked this pull request as draft March 28, 2024 14:43
@mikealfare mikealfare marked this pull request as ready for review March 28, 2024 16:17
@mikealfare mikealfare merged commit 02d7727 into main Mar 28, 2024
64 checks passed
@mikealfare mikealfare deleted the docker/fix-dbt-postgres branch March 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Docker release for dbt-postgres is broken
2 participants